Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

[Pavel Machek]

On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote:
> Hi Baolin,
> 
> On 09/21/2018 05:31 AM, Baolin Wang wrote:
> > Hi Jacek and Pavel,
> > 
> > On 11 September 2018 at 10:47, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> >> This patch adds one new led trigger that LED device can configure
> >> the software or hardware pattern and trigger it.
> >>
> >> Consumers can write 'pattern' file to enable the software pattern
> >> which alters the brightness for the specified duration with one
> >> software timer.
> >>
> >> Moreover consumers can write 'hw_pattern' file to enable the hardware
> >> pattern for some LED controllers which can autonomously control
> >> brightness over time, according to some preprogrammed hardware
> >> patterns.
> >>
> >> Signed-off-by: Raphael Teysseyre <rteysseyre@xxxxxxxxx>
> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>

> > Do you have any comments for the v12 patch set? Thanks.
> 
> We will probably have to remove hw_pattern from ledtrig-pattern
> since we are unable to come up with generic interface for it.
> Unless thread [0] will end up with some brilliant ideas. So far
> we're waiting for Pavel's reply.
> 
> [0] https://lkml.org/lkml/2018/9/13/1216

To paint a picture:

brightness

   rise hold          lower       hold down
  ^    XXXXXXXXXXXXXXX
  |   X               XX
  |  X                  XX
  | X                     XXXXXXXXXXXXXXXXXXXXXXXXXX
  +-------------------------------------------------------> time

This is what Baolin's hardware can do, right?

This is also what pattern trigger can do, right?

So all we need to do is match the two interfaces, so that hw_pattern
returns -EINVAL on patterns hardware can not actually do.

I believe I described code to do that in [0] above.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature