Re: [PATCH 10/11] UAPI: ndctl: Remove use of PAGE_SIZE [ver #2]

From: Dan Williams
Date: Tue Sep 25 2018 - 16:18:09 EST


On Thu, Sep 6, 2018 at 2:19 AM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> The macro PAGE_SIZE isn't valid outside of the kernel, so it should not
> appear in UAPI headers.
>
> Furthermore, the actual machine page size could theoretically change from
> an application's point of view if it's running in a container that gets
> migrated to another machine (say 4K/ppc64 to 64K/ppc64).
>
> Fixes: f2ba5a5baecf ("libnvdimm, namespace: make min namespace size 4K")
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Dan Williams <dan.j.williams@xxxxxxxxx>

Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Let me know if you want me to pick this up for 4.20.