Re: [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver
From: Dan Murphy
Date: Tue Sep 25 2018 - 17:20:30 EST
On 09/25/2018 02:39 PM, Rob Herring wrote:
> On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek <pavel@xxxxxx> wrote:
>>>> Add the device tree bindings for the lm3697
>>>> LED driver for backlighting and display.
>>>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>>>> .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++
>>>> 1 file changed, 86 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>> We already have binding for lm3697 in
>> Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to
>> have second one?
> Of course not. Now that you mention it, I do remember seeing some
> discussion on this.
I will be posting a RFC tomorrow with all the changes that shows 3 devices
attached to the common code along with extending out the features on the LED
Its not complete or tested code but it should give a basis for discussion. This way I
can do some other code while this is being discussed.