Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c
Date: Tue Sep 25 2018 - 22:29:22 EST
On Tue, Sep 25 2018, Joe Perches wrote:
> On Tue, 2018-09-25 at 20:49 +0200, Greg Kroah-Hartman wrote:
>> On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote:
>> > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote:
>> > > This patch fixes a few single statement macros in sd.c.
>> > > It converts two macros to inline functions. It removes
>> > > five other macros and replaces their usages with calls to
>> > > the function being called in the macro definition.
>> > > Issue found by checkpatch.
>> > >
>> > > Signed-off-by: Nishad Kamdar <nishadkamdar@xxxxxxxxx>
>> > > ---
>> > > Changes in v2:
>> > > - Convert msdc_gate_clk() and msdc_ungate_clk() to inline functions.
>> > > - Delete msdc_irq_restore(), msdc_vcore_on(), msdc_vcore_off(),
>> > > msdc_vdd_on() and msdc_vdd_off() and replace their usages directly
>> > > with calls to the function being called by these macros.
>> > Nishad, do please look again for uses of these functions
>> > you are changing.
>> > Please try removing all the #if 0 blocks instead, and then
>> > see if there are also now unused functions from those removed
>> > blocks that could also be removed.
>> > And Greg, if you look at this, look at the odd license of
>> > these files.
>> > It's possible the license is incompatible with the GPL.
>> It is odd, but the GPL at the bottom of the file kind of implies it is
> Implications are not licenses.
>> Given that it was published by mtk, I am assuming all is good, but
>> it would be a good idea to check with the authors to fix this up
> The initial patch was submitted by
> John Crispin <blogic@xxxxxxxxxxx>
Actually it was submitted by me. I extracted it from libreCMC (I think -
it is in most of the various openWRT-like distros).
In libreCMC the patch has John listed as the Author, and I thought it
right to preserve that.
I believe the code comes from a code-dump made by Mediatek several years
ago. It can be found at git://github.com/mqmaker/linux.git.
The code there contains (in drivers/mmc/host/mtk-mmc/sd.c) both the
copyright statement and the
I took this declaration as sufficient evidence that Mediatek
intentionally released it under the GPL. The fact that the whole
code dump contains the GPL COPYING file is extra evidence.
> I do not know John's relationship to mediatek.
> commit 8b634a9c7620b15691322cd53071122d2ab249a7
> Author: John Crispin <blogic@xxxxxxxxxxx>
> Date: Thu Mar 15 07:22:35 2018 +1100
> John? Any idea of the providence of these files?
> I do not see anything like it in
Description: PGP signature