Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

From: Rolf Eike Beer
Date: Thu Sep 27 2018 - 09:14:08 EST

Am 2018-09-27 13:23, schrieb Leonardo Bras:
Hello Rolf,

On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:
Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo BrÃs:
Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have
no meaning building alone.

Signed-off-by: Leonardo BrÃs <leobras.c@xxxxxxxxx>
drivers/oprofile/Makefile | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 drivers/oprofile/Makefile

diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
new file mode 100644
index 000000000000..acaed2ad6eee
--- /dev/null
+++ b/drivers/oprofile/Makefile
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.

Now there is a blank line where it does not need to be.


Oh, it's a Makefile, and as all text files, it have to end with newline.
If I am wrong, please let me know.

No, that's fine. But it means it has to have one LF after "tree.". It had none, now it hat 2.