Re: [PATCH v3 0/9] add support for relative references in jump tables

From: Kees Cook
Date: Thu Sep 27 2018 - 11:46:22 EST


On Wed, Sep 19, 2018 at 6:08 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Sep 18, 2018 at 11:51:35PM -0700, Ard Biesheuvel wrote:
>
>> Ard Biesheuvel (8):
>> kernel/jump_label: abstract jump_entry member accessors
>> kernel/jump_label: implement generic support for relative references
>> arm64/kernel: jump_label: switch to relative references
>> x86: add support for 64-bit place relative relocations
>> x86: jump_label: switch to jump_entry accessors
>> x86/kernel: jump_table: use relative references
>> jump_label: annotate entries that operate on __init code earlier
>> jump_table: move entries into ro_after_init region
>>
>> Heiko Carstens (1):
>> s390/jump_label: switch to relative references
>
> This all looks good to me;
>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>
> Ingo, could you queue this?

Seconded. :) (My Reviewed-by tags are already in the patches I've examined.)

Thanks!

-Kees

--
Kees Cook
Pixel Security