Re: [PATCH 06/13] staging:rtl8192u: Remove TxSTBC and RxSTBC - Style

From: Dan Carpenter
Date: Fri Sep 28 2018 - 10:33:10 EST


On Wed, Sep 26, 2018 at 08:16:57PM +0100, John Whitmore wrote:
> Remove the member variables TxSTBC and RxSTBC as neither is used in
> code.
>
> This is a coding style change which should not impact runtime code
> execution.
>
> Signed-off-by: John Whitmore <johnfwhitmore@xxxxxxxxx>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 --
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 3 ---
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> index 83fb8f34ccbd..52cce0dcf9a5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> @@ -43,8 +43,6 @@ struct ht_capability_ele {
> u8 MimoPwrSave:2;
> u8 ShortGI20Mhz:1;
> u8 ShortGI40Mhz:1;
> - u8 TxSTBC:1;
> - u8 RxSTBC:2;
> u8 DelayBA:1;
> u8 MaxAMSDUSize:1;
> u8 DssCCk:1;

Same thing. I suspect his is set by the firmware.

regards,
dan carpenter