Re: [PATCH 0/8] [v2] x86/mm: page fault handling cleanups

From: Peter Zijlstra
Date: Tue Oct 02 2018 - 05:54:40 EST


On Fri, Sep 28, 2018 at 09:02:19AM -0700, Dave Hansen wrote:
> Changes from v1:
> * Take "space_" out of do_kern/user_addr_fault()
> * Make "bad fault" comment in do_kern_addr_fault() less scary
> * Add clarifying comment for the conditions under which
> do_kern_addr_fault() is called.
> * Remove mention of hw_error_code in search_exception_tables()
> comment.
> * Clarify that the exception tables spell out individual
> instructions, not larger sections of code.
> * Use PAGE_MASK in is_vsyscall_vaddr()
> * Add some additional reasoning behind the code move when
> moving the vsyscall handling to user address space handler
> * Remove hard-coded ~0xfff and replace with PAGE_MASK
>

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>