RE: [PATCH] EDAC: Don't add devices under /sys/bus/edac

From: Ernst, Justin
Date: Tue Oct 02 2018 - 11:51:49 EST


The combined patches work on a 20 socket system.
Thanks!
-Justin

> -----Original Message-----
> From: Mauro Carvalho Chehab [mailto:mchehab+samsung@xxxxxxxxxx]
> Sent: Monday, October 1, 2018 8:23 PM
> To: Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>; Anderson, Russ
> <russ.anderson@xxxxxxx>; Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; Ernst,
> Justin <justin.ernst@xxxxxxx>; Anderson, Russ <russ.anderson@xxxxxxx>;
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; linux-
> edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Aristeu Rozanski Filho
> <arozansk@xxxxxxxxxx>
> Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac
>
> Em Mon, 1 Oct 2018 15:43:13 -0700
> "Luck, Tony" <tony.luck@xxxxxxxxx> escreveu:
>
> > Nobody(*) uses them. Dropping this will allow us to make the total
> > number of memory controllers configurable (as we won't have to
> > worry about duplicated device names under this directory).
> >
> > (*) https://marc.info/?l=linux-edac&m=153809709903987&w=2
> >
> > Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> > ---
> >
> > Boris: Apply this, then your earlier patch to get rid of the
> > hard coded limit on the number of memory controllers:
> > https://marc.info/?l=linux-edac&m=153797567628947&w=2
> > the combination works on my 4 socket machine. Perhaps HPE
> > can test on their superdome.
> >
>
> For both this and the referred patch:
>
> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
>
> > drivers/edac/edac_mc_sysfs.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> > index 20374b8248f0..4c1bee59c2e6 100644
> > --- a/drivers/edac/edac_mc_sysfs.c
> > +++ b/drivers/edac/edac_mc_sysfs.c
> > @@ -405,7 +405,6 @@ static int edac_create_csrow_object(struct
> mem_ctl_info *mci,
> > struct csrow_info *csrow, int index)
> > {
> > csrow->dev.type = &csrow_attr_type;
> > - csrow->dev.bus = mci->bus;
> > csrow->dev.groups = csrow_dev_groups;
> > device_initialize(&csrow->dev);
> > csrow->dev.parent = &mci->dev;
> > @@ -636,7 +635,6 @@ static int edac_create_dimm_object(struct
> mem_ctl_info *mci,
> > dimm->mci = mci;
> >
> > dimm->dev.type = &dimm_attr_type;
> > - dimm->dev.bus = mci->bus;
> > device_initialize(&dimm->dev);
> >
> > dimm->dev.parent = &mci->dev;
> > @@ -940,7 +938,6 @@ int edac_create_sysfs_mci_device(struct
> mem_ctl_info *mci,
> > device_initialize(&mci->dev);
> >
> > mci->dev.parent = mci_pdev;
> > - mci->dev.bus = mci->bus;
> > mci->dev.groups = groups;
> > dev_set_name(&mci->dev, "mc%d", mci->mc_idx);
> > dev_set_drvdata(&mci->dev, mci);
>
>
>
> Thanks,
> Mauro