Re: [PATCH 2/2] cdc-acm: correct counting of UART states in serial state notification

From: Greg KH
Date: Tue Oct 02 2018 - 13:34:20 EST


On Sat, Sep 22, 2018 at 10:11:11PM +0200, Tobias Herzog wrote:
> The usb standard ("Universal Serial Bus Class Definitions for Communication
> Devices") distiguishes between "consistent signals" (DSR, DCD), and
> "irregular signals" (break, ring, parity error, framing error, overrun).
> The bits of "irregular signals" are set, if this error/event occurred on
> the device side and are immeadeatly unset, if the serial state notification
> was sent.
> Like other drivers of real serial ports do, just the occurence of those
> events should be counted in serial_icounter_struct (but no 1->0
> transitions).
>
> Signed-off-by: Tobias Herzog <t-herzog@xxxxxx>
> ---
> drivers/usb/class/cdc-acm.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

Oliver, any thoughts about this patch series?

thanks,

greg k-h