Re: [PATCH 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

From: Chen-Yu Tsai
Date: Wed Oct 03 2018 - 03:34:28 EST


On Wed, Oct 3, 2018 at 5:59 AM Giulio Benetti
<giulio.benetti@xxxxxxxxxxxxxxxx> wrote:
>
> If using tcon with VGA, tcon->panel will be null(0), this will cause
> segmentation fault when trying to dereference tcon->panel->connector.
>
> Add tcon->panel null check before calling
> sun4i_tcon0_mode_set_dithering().
>
> Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>

Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for
RGB565/RGB666 LCD panels")

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>