Re: [PATCH v8 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment

From: Punit Agrawal
Date: Wed Oct 03 2018 - 06:59:19 EST


Marc Zyngier <marc.zyngier@xxxxxxx> writes:

> On 01/10/18 16:54, Punit Agrawal wrote:
>> PageTransCompoundMap() returns true for hugetlbfs and THP
>> hugepages. This behaviour incorrectly leads to stage 2 faults for
>> unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be
>> treated as THP faults.
>>
>> Tighten the check to filter out hugetlbfs pages. This also leads to
>> consistently mapping all unsupported hugepage sizes as PTE level
>> entries at stage 2.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
>> Reviewed-by: Suzuki Poulose <suzuki.poulose@xxxxxxx>
>> Cc: Christoffer Dall <christoffer.dall@xxxxxxx>
>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx # v4.13+
>
> FWIW, I've cherry-picked that single patch from the series and queued
> it for 4.20.

Thanks for picking up the fix.