Re: [PATCH 1/7] mpt3sas: Add ioc_<level> logging macros

From: Suganath Prabu Subramani
Date: Thu Oct 04 2018 - 06:25:21 EST


Hi,
Please consider this patch as Acked-by: Suganath Prabu
<suganath-prabu.subramani@xxxxxxxxxxxx>

Thanks.
On Mon, Sep 17, 2018 at 8:31 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> These macros can help identify specific logging uses and eventually
> perhaps reduce object sizes.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h
> index 96dc15e90bd8..941a4faf20be 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.h
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h
> @@ -160,6 +160,15 @@ struct mpt3sas_nvme_cmd {
> */
> #define MPT3SAS_FMT "%s: "
>
> +#define ioc_err(ioc, fmt, ...) \
> + pr_err("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_notice(ioc, fmt, ...) \
> + pr_notice("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_warn(ioc, fmt, ...) \
> + pr_warn("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +#define ioc_info(ioc, fmt, ...) \
> + pr_info("%s: " fmt, (ioc)->name, ##__VA_ARGS__)
> +
> /*
> * WarpDrive Specific Log codes
> */
> --
> 2.15.0
>