Re: [PATCH] rtc: m41t80: fix fall-through annotation

From: Gustavo A. R. Silva
Date: Thu Oct 04 2018 - 09:49:07 EST




On 10/4/18 2:53 PM, Alexandre Belloni wrote:
> Hi,
>
> On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote:
>> Replace "Fall" with a proper "Fall through" annotation.
>>
>> This fix is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough
>>
>
> Can we agree that this is absolutely not a fix? I don't wan't to have
> that needlessly backport on gazillion stable kernel.
>

Well, as clearly the intention of the developer was to add a fall-through
comment, but it was incomplete, I considered this a fix. But, I see your
point and I agree. There is not need for this to be applied to stable trees.

I will change the subject.

Thanks
--
Gustavo