Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

From: Maxime Ripard
Date: Mon Oct 08 2018 - 05:21:26 EST


On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote:
> If tcon->panel pointer is NULL, trying to dereference from it
> (i.e. tcon->panel->connector) will cause a null pointer dereference.
>
> Add tcon->panel null pointer check before calling
> sun4i_tcon0_mode_set_dithering().
>
> Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>
> Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for
> RGB565/RGB666 LCD panels")
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>

Applied both, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature