Re: [PATCH 2/8] drivers: of: ifdef out cmdline section

From: Maksym Kokhan
Date: Mon Oct 08 2018 - 13:59:13 EST


Hi, Rob

On Fri, Sep 28, 2018 at 12:07 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
>
> On Thu, Sep 27, 2018 at 11:55 AM Maksym Kokhan
> <maksym.kokhan@xxxxxxxxxxxxxxx> wrote:
> >
> > From: Daniel Walker <danielwa@xxxxxxxxx>
> >
> > It looks like there's some seepage of cmdline stuff into
> > the generic device tree code. This conflicts with the
> > generic cmdline implementation so I remove it in the case
> > when that's enabled.
>
> What's preventing removing this or simplifying the DT code to just be
> "give me the cmdline data from DT" and the common code deals with all
> the combinations of config options.

This code (handling built-in cmdline in old, non-generic way) is used by
some other architectures besides those, modified in our patches, so for
now we can't remove it.

Thanks,
Maksym