Re: [PATCH] usbip: vhci_hcd: check port number before using
From: Shuah Khan
Date: Mon Oct 08 2018 - 16:06:38 EST
On 10/08/2018 02:01 PM, Sudip Mukherjee wrote:
> On Mon, Oct 8, 2018 at 8:29 PM Shuah Khan <shuah@xxxxxxxxxx> wrote:
>> Hi Sudip,
>> On 10/08/2018 01:19 PM, Sudip Mukherjee wrote:
>>> From: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
>>> The port number is checked and it just prints an error message but it
>>> still continues to use the invalid port. And as a result it accesses
>>> memory which is not its resulting in BUG report from KASAN.
>> Yes there is an issue with out of bounds access. But this isn't the
>> right fix.
>>> Reported-by: syzbot+600b03e0cf1b73bb23c4@xxxxxxxxxxxxxxxxxxxxxxxxx
>>> Cc: stable <stable@xxxxxxxxxxxxxxx>
>>> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
>> I sent in a fix for this last Friday.
> And I can confirm this patch also fixes the issue tested with the
> reproducer I was using in my vm.
Great Thanks for testing the patch.