Re: [PATCH 2/3] lib/vsprintf: Hash legacy clock addresses

From: Petr Mladek
Date: Tue Oct 09 2018 - 10:05:45 EST


On Mon 2018-10-08 13:05:03, Geert Uytterhoeven wrote:
> On platforms using the Common Clock Framework, "%pC" prints the clock's
> name. On legacy platforms, it prints the unhashed clock's address,
> potentially leaking sensitive information regarding the kernel layout in
> memory.
>
> Avoid this leak by printing the hashed address instead. To distinguish
> between clocks, a 32-bit unique identifier is as good as an actual
> pointer value.
>
> Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

It makes sense.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr