Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8

[Greg Kroah-Hartman]

On Tue, Oct 09, 2018 at 01:55:06PM +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Tuesday, October 9, 2018 8:45 AM
> > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Wentland, Harry
> > <Harry.Wentland@xxxxxxx>; Zhu, Rex <Rex.Zhu@xxxxxxx>; Sasha Levin
> > <alexander.levin@xxxxxxxxxxxxx>
> > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
> > for smu7/8
> > 
> > On Mon, Oct 08, 2018 at 06:01:50PM +0000, Deucher, Alexander wrote:
> > > > -----Original Message-----
> > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Sent: Monday, October 8, 2018 1:11 PM
> > > > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Wentland,
> > > > Harry <Harry.Wentland@xxxxxxx>; Zhu, Rex <Rex.Zhu@xxxxxxx>;
> > Sasha
> > > > Levin <alexander.levin@xxxxxxxxxxxxx>
> > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values
> > > > to DC for smu7/8
> > > >
> > > > On Mon, Oct 08, 2018 at 04:02:19PM +0000, Deucher, Alexander wrote:
> > > > > > -----Original Message-----
> > > > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > > Sent: Monday, October 8, 2018 10:44 AM
> > > > > > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> > > > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx;
> > > > > > Wentland, Harry <Harry.Wentland@xxxxxxx>; Zhu, Rex
> > > > > > <Rex.Zhu@xxxxxxx>;
> > > > Sasha
> > > > > > Levin <alexander.levin@xxxxxxxxxxxxx>
> > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock
> > > > > > values to DC for smu7/8
> > > > > >
> > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +0000, Deucher, Alexander
> > wrote:
> > > > > > > > -----Original Message-----
> > > > > > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > > > > Sent: Monday, September 24, 2018 7:53 AM
> > > > > > > > To: linux-kernel@xxxxxxxxxxxxxxx
> > > > > > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>;
> > > > > > > > stable@xxxxxxxxxxxxxxx; Wentland, Harry
> > > > > > > > <Harry.Wentland@xxxxxxx>; Deucher, Alexander
> > > > > > > > <Alexander.Deucher@xxxxxxx>; Zhu, Rex
> > <Rex.Zhu@xxxxxxx>;
> > > > Sasha
> > > > > > > > Levin <alexander.levin@xxxxxxxxxxxxx>
> > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock
> > > > > > > > values to DC for
> > > > > > > > smu7/8
> > > > > > > >
> > > > > > > > 4.18-stable review patch.  If anyone has any objections,
> > > > > > > > please let me
> > > > > > know.
> > > > > > > >
> > > > > > >
> > > > > > > This regresses power usage on 4.18.  Please revert.
> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275
> > > > > >
> > > > > > Is it reverted in "upstream" as well?  If not, please get the
> > > > > > fix in there and then I will be glad to backport it here.
> > > > > >
> > > > >
> > > > > There's no breakage in upstream.  This patch addressed breakages
> > > > > in
> > > > > 4.19 specifically due to some other refactoring we did in the driver.
> > > > > I'll try and dig out the exact series of patches this addressed.
> > > >
> > > > So there is no problem in 4.19-rc7?  That contridicts the statement
> > > > of looking in drm-next for the fixes.
> > >
> > > Sorry, what statement about drm-next?  This patch was for 4.19 and was
> > not intended for 4.18.  It was picked up by Sasha's auto select system for
> > stable.
> > 
> > I thought this thread said that.
> > 
> > Ok, so I should just revert it?
> 
> Yes, please.

Now reverted, thanks.

greg k-h