Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning

From: Jeffrey Hugo
Date: Tue Oct 09 2018 - 13:14:51 EST


On 10/5/2018 10:54 AM, Timur Tabi wrote:
On 10/05/2018 11:17 AM, Jeffrey Hugo wrote:>
Looks like the driver is initing just fine to me. Is setting up the
jumpers and running gpio-test warranted?

Well, that test only makes sure that input/output is actually working
on the hardware level, but it also makes sure that the GPIOs are
numbered correctly.

If you want, just put a printk(... offset) in msm_gpio_get() and read
from a GPIO that you know you have access to, and make sure the
'offset' is correct.

Then try reading from a GPIO that you don't have access to, and make
sure you get a failure before msm_gpio_get() is called.


Done.

For the series:

Tested-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>

--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.