Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()
From: Joel Stanley
Date: Wed Oct 10 2018 - 02:10:43 EST
On Thu, 27 Sep 2018 at 05:07, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Wed, Sep 26, 2018 at 12:29 PM, Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx> wrote:
> > On Wed, Sep 26, 2018 at 12:03 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >> On Wed, Sep 26, 2018 at 11:45:19AM -0700, Kees Cook wrote:
> >> > On Wed, Sep 26, 2018 at 11:42 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >> > > I'm not digging up a compiler.h patch from a web site and adding it to
> >> > > the tree this late in the release cycle. Especially given that it
> >> > > hasn't had any testing anywhere...
> >> >
> >> > Good point about it not living in -next.
> >> >
> >> > Who should be carrying these sorts of patches? In the past it's been
> >> > Andrew or Masahiro, yes? For linux-next, maybe it can go via -mm?
> >> Either is fine with me, as long as it isn't one of my trees :)
> >> thanks,
> >> greg k-h
> > Besides, I think we want the v2: https://lkml.org/lkml/2018/8/25/103
> Yeah, that's what I'd linked to in the patchwork URL. Andrew, can you take this?
clang built -next is blowing up now that Kees' -Wvla patch has been
included. This patch fixes it.
Kees, perhaps it should go in your tree along side of the -Wvla patch
if no one else wants to take it?