Re: [PATCH] ceph: only allow punch hole mode in fallocate
From: Luis Henriques
Date: Wed Oct 10 2018 - 07:19:43 EST
Ilya Dryomov <idryomov@xxxxxxxxx> writes:
> On Wed, Oct 10, 2018 at 6:21 AM Yan, Zheng <ukernel@xxxxxxxxx> wrote:
>> On Wed, Oct 10, 2018 at 1:54 AM Luis Henriques <lhenriques@xxxxxxxx> wrote:
>> Applied, thanks
> I don't think it should go to stable kernels. Strictly speaking it's
> a behaviour change -- it's been this way for many years and, unless you
> are close to ENOSPC, it's sort of appears to work. I'll take off the
> stable tag unless I hear objections.
Right, it can in fact break applications that rely on the previous
(bogus) behaviour. But it can also be claimed that it *will* break
applications anyway with an updated kernel, so backporting it to older
kernels will just allow a consistent behaviour.
Anyway, I'm OK either way. But if you drop the stable tag make sure you
also remove the 'Fixes:' tag as I believe the stable folks will still
pick this patch if it includes a valid SHA1 in it.