Re: [PATCH 3/5] spi: pxa2xx: use an enum for type

From: Lubomir Rintel
Date: Wed Oct 10 2018 - 13:27:07 EST

On Fri, 2018-09-21 at 22:34 +0200, Robert Jarzmik wrote:
> Lubomir Rintel <lkundrak@xxxxx> writes:
> > That seems to be the correct type.
> Okay, but what happens here when adev_id->driver_data is a value out
> of enum
> range ? Does the following assignment make sense ?
> > + type = (enum pxa_ssp_type)adev_id->driver_data;
> As a side note, could you join for the next throw to the review :
> - Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> - Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Argh, of course I forgot. My apologies.

Jarkko & Mika, I'm wondering if you could take a look at the [1] thread
and tell me what you think. (I can forward it to you via e-mail too, if
you're not subscribed to lists it has been Cc'd to, if that would be
more convenient).

[1] [PATCH 0/11] spi: pxa2xx: add DT and slave mode support"


> Even if they are Intel, I think they have worked a lot on this driver
> for Intel
> platforms.
> Cheers.