Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)
From: Rasmus Villemoes
Date: Thu Oct 11 2018 - 06:11:42 EST
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes<linux@xxxxxxxxxxxxxxxxxx>
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
> What's the problem you're fixing here ?
No problem, really, other than my inner Paul Hogan telling me "That's
not an insertion sort, ...".
> Is it tested ?
Compile-tested. As I said, if the performance (and inaccurate comment)
is irrelevant, just drop it.