RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

[Vitaly Kuznetsov]

Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> writes:

>> -----Original Message-----
>> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxxxxxx>
>> Sent: Thursday, October 11, 2018 4:15 PM
>> To: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx
>> Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; KY Srinivasan
>> <kys@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
>> olaf@xxxxxxxxx; vkuznets <vkuznets@xxxxxxxxxx>;
>> devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info
>> 
>> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>> 
>> The VF device's serial number is saved as a string in PCI slot's kobj name, not
>> the slot->number. This patch corrects the netvsc driver, so the VF device can be
>> successfully paired with synthetic NIC.
>> 
>> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")
>> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>
> Thanks Stephen for the reminder -- I added the "reported-by" here:
>
> Reported-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Thanks) 

The difference in the hack I sent to Stephen was that instead of using
kstrtou32() and checking the return value I opted for snprintf() and
doing strncmp().

-- 
Vitaly