Re: [PATCH v2 4/4] locking/qspinlock, x86: Provide liveness guarantee

From: Will Deacon
Date: Fri Oct 12 2018 - 05:22:12 EST


On Wed, Oct 10, 2018 at 05:12:57PM +0100, Will Deacon wrote:
> On Wed, Oct 03, 2018 at 03:03:01PM +0200, Peter Zijlstra wrote:
> > arch/x86/include/asm/qspinlock.h | 15 +++++++++++++++
> > kernel/locking/qspinlock.c | 16 +++++++++++++++-
> > 2 files changed, 30 insertions(+), 1 deletion(-)
>
> I've failed to break this by thinking really hard, so I've updated Catalin's
> TLA model to see if the tools are still happy. I'll get back to you once
> they've finished chewing on it.

The model is happy, so this doesn't introduce any "bad" SC behaviours.

Reviewed-by: Will Deacon <will.deacon@xxxxxxx>

Will