Re: [PATCH v3 2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain

From: Rob Herring
Date: Fri Oct 12 2018 - 10:47:05 EST


On Fri, Sep 28, 2018 at 03:01:50PM +0200, Pierre-Yves MORDRET wrote:
> From: M'boumba Cedric Madianga <cedric.madianga@xxxxxxxxx>
>
> Add one cell to support DMA/MDMA chaining.

You aren't adding a cell. Is the change compatible with existing users
(if you mask bits)?

>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@xxxxxx>

Author S-o-b missing.

> ---
> Version history:
> v3:
> v2:
> * rework content
> v1:
> * Initial
> ---
> ---
> Documentation/devicetree/bindings/dma/stm32-dmamux.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/stm32-dmamux.txt b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> index 1b893b2..5e92b59 100644
> --- a/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> +++ b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> @@ -4,9 +4,9 @@ Required properties:
> - compatible: "st,stm32h7-dmamux"
> - reg: Memory map for accessing module
> - #dma-cells: Should be set to <3>.
> - First parameter is request line number.
> - Second is DMA channel configuration
> - Third is Fifo threshold
> +- First parameter is request line number.
> +- Second is DMA channel configuration
> +- Third is a 32bit bitfield
> For more details about the three cells, please see
> stm32-dma.txt documentation binding file
> - dma-masters: Phandle pointing to the DMA controllers.
> --
> 2.7.4
>