Re: [PATCH] ubifs: Fix WARN_ON logic in exit path

From: Greg KH
Date: Sat Oct 13 2018 - 05:34:29 EST


On Sat, Oct 13, 2018 at 10:18:41AM +0200, Richard Weinberger wrote:
> ubifs_assert() is not WARN_ON(), so we have to invert
> the checks.
> Randy faced this warning with UBIFS being a module, since
> most users use UBIFS as builtin because UBIFS is the rootfs
> nobody noticed so far. :-(
> Including me.
>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Fixes: 54169ddd382d ("ubifs: Turn two ubifs_assert() into a WARN_ON()")
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> Greg,
>
> can you please take this patch directly?
> It fixes a brown paper bug which was introduced in rc1, I'd like to avoid
> having it in a release and going the -stable path.

Now merged, thanks.

greg k-h