Re: [PATCH v8 3/5] Cleanup ISA string setting

From: Guenter Roeck
Date: Sun Oct 14 2018 - 22:13:35 EST

Hi Alan,

On 10/14/2018 04:46 PM, Alan Kao wrote:
Hi Guenter,

On Sat, Oct 13, 2018 at 05:02:05PM -0700, Guenter Roeck wrote:

With this patch in -next applied, I get the following error
when building riscv:defconfig.

I guess what you meant was this commit:
commit 0a5bee05fc67ce2044b8d91a18abbf14042da531

Yes, sorry, I just blindly assumed that the last version I found must have caused
the problem. You are right, v8 actually fixes it (as suggested below).

The modification in Makefile was

+# ISA string setting
+riscv-march-$(CONFIG_ARCH_RV32I) := rv32im
+riscv-march-$(CONFIG_ARCH_RV64I) := rv64im
+riscv-march-$(CONFIG_RISCV_ISA_A) := $(riscv-march-y)aj
+riscv-march-y := fd
+riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c

and the ":= fd" line was wrong. It should have been

+riscv-march-y := $(riscv-march-y)fd

What am I missing ? Does RISC-V now require a new non-upstream compiler ?
Or a special version of make ? I am currently using GNU Make 4.1.

So I sent the v8 to fix this problem.
Sorry for the inconvinience.

No worries. At least this problem was (is going to be) easy to fix.
And, yes, I confirmed that the one-line change above fixes the problem.




And Palmer, it seems that the patch that causes this build error has been
pulled into linux-next. Any idea how to fix that one?

Many thanks,