Re: [PATCH 01/11] staging: gasket: core: debug log updates

[Greg Kroah-Hartman]

On Sun, Oct 14, 2018 at 09:59:17PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
> 
> Add debug logs for device enable/disable events,

Why?

What is going to need this?

> remove logs for
> callbacks (the called functions can generate their own logs if needed).

That's a different thing than "adding" them, so shouldn't this really be
2 patches?  If it was, I could have accepted this patch already, and
ignored the "add new logs" one :)

thanks,

greg k-h