Re: [PATCH] x86/entry/32: Fix setup of CS high bits

[Jan Kiszka]

On 15.10.18 15:14, David Laight wrote:
> From: Jan Kiszka
> > Sent: 15 October 2018 14:09
> ...
> > > Those fields are genuinely 16 bit.  So the comment should say
> > > something like "Those high bits are used for CS_FROM_ENTRY_STACK and
> > > CS_FROM_USER_CR3".
> >
> > /*
> >    * The high bits of the CS dword (__csh) are used for
> >    * CS_FROM_ENTRY_STACK and CS_FROM_USER_CR3. Clear them in case
> >    * hardware didn't do this for us.
> >    */
>
> What's a 'dword' ? :-)
>
> On a 32bit processor a 'word' will be 32 bits to a 'double-word'
> would be 64 bits.
> One of the worst names to use.

That's ia32 nomenclature: a doubleword (dword) is a 32-bit value.

Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux