Re: [PATCH v3 09/15] platform: goldfish: pipe: Move goldfish_pipe to goldfish_pipe_v2

From: Greg KH
Date: Mon Oct 15 2018 - 14:38:12 EST


On Wed, Oct 03, 2018 at 10:17:14AM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
>
> This is the v2 driver. v1 will be added later.

This does not make any sense. Why are you renaming a driver that has
been in the tree already? It's not "v2", it is what we have today.

If you want to add a new driver later, great, but don't change the name
of an existing driver for no good reason. Userspace has a tendancy to
break when that happens.

thanks,

greg k-h