Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables

From: Borislav Petkov
Date: Tue Oct 16 2018 - 08:41:00 EST

On Tue, Oct 16, 2018 at 10:48:44AM +0800, Chao Fan wrote:
> Sorry for disturbing you again, I want to make sure this detail with you.
> You mean that I need splite this as a function and put it to
> cmdline.c, right?

Extract that functionality into a generic helper so that
handle_mem_options() and your get_acpi_rsdp() can call it instead
of duplicating the code. Also, why aren't they both using
cmdline_find_option() directly?

If something's missing, extend cmdline_find_option() to serve your
purposes too instead of copying the same code.

Make more sense?


Good mailing practices for 400: avoid top-posting and trim the reply.