Re: patch "staging: MAINTAINERS: remove obsolete IPX staging directory" added to staging-testing

From: Joe Perches
Date: Tue Oct 16 2018 - 13:11:49 EST


On Tue, 2018-10-16 at 13:51 +0200, Greg KH wrote:
> On Tue, Oct 16, 2018 at 04:43:30AM -0700, Joe Perches wrote:
> > On Tue, 2018-10-16 at 12:46 +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > > This is a note to let you know that I've just added the patch titled
> > >
> > > staging: MAINTAINERS: remove obsolete IPX staging directoryts
> > []
> > > From dd71c89b2c1ae049d2018107e9d7a41261db3f7b Mon Sep 17 00:00:00 2001
> > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Date: Tue, 16 Oct 2018 12:45:13 +0200
> > > Subject: staging: MAINTAINERS: remove obsolete IPX staging directory
> > >
> > > The IPX code was removed from staging back in November 2017, but the
> > > MAINTAINERS entry stuck around. Remove the invalid directory from the
> > > file as it does not actually point to anything anymore.
> >
> > As the uapi ipx file still exists but the functionality
> > has been removed, perhaps some compiler message like
> >
> > #pragma message "IPX functionality removed as of linux kernel v4.18"
> >
> > should be added to the uapi file.
>
> Eventually those files should be removed by the networking developers.
> It will take a bit of work for them to do it, it's not a straight
> "delete the file" work.

I understand that, but it's not the point.

#pragma message might still be useful because,
in the meantime, anyone
actually including the
uapi file would get some heads-up notification
that IPX doesn't work here anymore.