RE: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()

From: David Laight
Date: Wed Oct 17 2018 - 07:46:02 EST

From: 'Sebastian Andrzej Siewior'
> Sent: 17 October 2018 11:39
> On 2018-10-17 09:54:38 [+0000], David Laight wrote:
> > Can it make any sense to flush the tlb with preemption enabled?
> it might. Usually it is disabled for other reasons.

That's what I mean, it should be disabled by the caller.

> > Surely preemption must be disabled over something else as well?
> In this case it is due to the CR3 reload. I don't see anything else.

Right, so it should be disabled before the CR3 reload and enabled after?


Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)