Re: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()
From: Peter Zijlstra
Date: Wed Oct 17 2018 - 12:23:11 EST
On Wed, Oct 17, 2018 at 06:00:51PM +0200, 'Sebastian Andrzej Siewior' wrote:
> On 2018-10-17 17:47:07 [+0200], Peter Zijlstra wrote:
> > > > Ideally we'd never ever merge anything that only does local invalidates,
> > > > on a global address space, that's just broken.
> > >
> > > A little bit late to lament about that.
> > For this, yes :/ But for future stuff we should really not allow such
> > things anymore.
> so we stay as is?
Well, we can do that preempt kludge you propose to shut up the warning I
But a kludge it is. That code really wants a global invalidate, but we
cannot (not without massive surgery in any case).