Re: [PATCH v13 02/12] livepatch: Helper macros to define livepatch structures
From: Josh Poimboeuf
Date: Wed Oct 17 2018 - 14:18:05 EST
On Mon, Oct 15, 2018 at 02:37:03PM +0200, Petr Mladek wrote:
> The definition of struct klp_func might be a bit confusing.
> The original function is defined by name as a string.
> The new function is defined by name as a function pointer
> casted to unsigned long.
> This patch adds helper macros that hide the different types.
> The functions are defined just by the name. For example:
On one hand, these macros are kind of nice, because they do the function
pointer casting for the user.
On the other hand, they hide the field names, which hurts readability a
bit. For example, it would be easy to accidentally assign the wrong
Also, it's unfortunate that these macros are needed in the first place.
What if we just change new_addr (and old_addr) to be 'void *'? Then the
macros wouldn't be as useful, and we could just get rid of them.