Re: [PATCH 1/3] kbuild: Add -Wshadow to sparse
From: Luc Van Oostenryck
Date: Wed Oct 17 2018 - 15:25:08 EST
On Wed, Oct 17, 2018 at 07:05:52PM +0200, Sebastian Andrzej Siewior wrote:
> I remember that `sparse' used to warn about shadowed variables but it
> seems not to do it by default anymore. It was useful.
> Enable `-Wshadow' while invoking sparse.
I made a quick test and I saw it would add a lot of noise because of
(valid) warnings coming from macros using a statement expression
redeclaring variables like '__u', 'tmp', ...
BTW, as far as I can see, sparse never had it enabled by default.
-- Luc Van Oostenryck