Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

From: Jeffrey Hugo
Date: Wed Oct 17 2018 - 18:41:42 EST

On 10/17/2018 4:32 PM, Andrew Morton wrote:
On Wed, 17 Oct 2018 16:21:08 -0600 Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx> wrote:

On 10/17/2018 4:05 PM, Andrew Morton wrote:
On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:

Cc: Arnd Bergmann <arnd@xxxxxxxx>
Co-developed-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

This should have Arnd's Signed-off-by: as well.

I'm just interested to know, why?

So that Arnd certifies that

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

and all the other stuff in Documentation/process/submitting-patches.rst
section 11!

Also, because section 12 says so :) And that final sentence is, I
believe, appropriate.

Ah, interesting. I see that the documentation was updated since I was told last year in the same situation by a different maintainer that co-authors should not have SOB lines on the patch.

Good to know. Thanks for illuminating me.

Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.