Re: [PATCH v2] drm/bochs: add edid support.

From: Gerd Hoffmann
Date: Thu Oct 18 2018 - 01:11:06 EST


> > Recent qemu (latest master branch, upcoming 3.1 release) got support
> > for EDID data. This patch adds guest driver support.
> >
> > EDID support in qemu is not (yet) enabled by default, so please use
> > 'qemu -device VGA,edid=on' for testing.
> The EDID never changes after boot?

Right now it doesn't.

> Is there plans to let it?

Needs more virtual hardware changes, the stdvga has no support for
interrupts, so qemu can't signal an edid update to the guest.

So not not sure yet what to do about it. Maybe add it later (but it's
not high priority). Maybe simply recommend to use virtio-gpu instead.

> > + kfree(bochs->edid);
> > + bochs->edid = kmalloc(len, GFP_KERNEL);
> Don't you need to free it somewhere?

Oh, yes, we leak that on driver unload.
I'll fix it.