Re: [PATCH 5/8] drm/virtio: track created object state
From: Gerd Hoffmann
Date: Thu Oct 18 2018 - 01:57:46 EST
On Thu, Oct 18, 2018 at 11:25:22AM +1000, Dave Airlie wrote:
> On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> > Track whenever the virtio_gpu_object is already created (i.e. host knows
> > about it) in a new variable. Add checks to virtio_gpu_object_attach()
> > to do nothing on objects not created yet.
> > Make virtio_gpu_ttm_bo_destroy() use the new variable too, instead of
> > expecting hw_res_handle indicating the object state.
> Is there a potential patch ordering issue here? If this patch changes
> the code to avoid using hw_res_handle,
> is after patches that start filling in hw_res_handle in places we
> haven't filled it in before.
> Maybe this patch should happen earlier.
Didn't run into trouble in testing, but yes, it might be an issue in
error paths. I'll reorder the patches.