Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails
From: Sudeep Holla
Date: Thu Oct 18 2018 - 05:15:56 EST
On Thu, Oct 18, 2018 at 09:28:11AM +0800, Huacai Chen wrote:
> Hi, Sudeep,
> Please see this call-graph:
> static int detect_cache_attributes(unsigned int cpu)
> ret = populate_cache_leaves(cpu);
> ret = cache_shared_cpu_map_setup(cpu); -->
> cache_setup_of_node() --> cache_of_set_props() -->
> populate_cache_leaves() is arch-specific, All archs except arm64 have
> provide initial values to cacheinfo:size and cacheinfo:number_of_sets.
> Related files:
Only above 2 could be affected, but I want to be sure. I wasn't aware
of MIPS arch setting values elsewhere, assumed DT, my bad.
You have still not answered my question. Which arch are you facing issue ?
Or are you proposing this by code inspection ? I changes look fine, but
want to be sure if the issue you are seeing is in above architectures.