Re: [PATCH 05/11] x86/fpu: set PKRU state for kernel threads
From: Dave Hansen
Date: Thu Oct 18 2018 - 13:48:05 EST
On 10/18/2018 09:48 AM, Andy Lutomirski wrote:
>>>> We might want to do this for cleanliness reasons... Maybe.
>>>> But this *should* have no practical effects. Kernel threads have no
>>>> real 'mm' and no user pages. They should not have do access to user
>>>> mappings. Protection keys *only* apply to user mappings. Thus,
>>>> logically, they should never be affected by PKRU values.
>>>> So I'm kinda missing the point of the patch.
>> So. I would drop that patch from queue. Anyone feels different about it?
> I think we *do* want the patch. Itâs a bugfix for use_mm users, right?
Yes, we need it. I was being dense and Andy kindly reminded me of the
point of the patch.