Re: [PATCH v4 09/18] of: overlay: validate overlay properties #address-cells and #size-cells

From: Frank Rowand
Date: Thu Oct 18 2018 - 15:13:08 EST

On 10/18/18 11:13, Rob Herring wrote:
> On Mon, Oct 15, 2018 at 07:37:29PM -0700, frowand.list@xxxxxxxxx wrote:
>> From: Frank Rowand <frank.rowand@xxxxxxxx>
>> If overlay properties #address-cells or #size-cells are already in
>> the live devicetree for any given node, then the values in the
>> overlay must match the values in the live tree.
>> If the properties are already in the live tree then there is no
>> need to create a changeset entry to add them since they must
>> have the same value. This reduces the memory used by the
>> changeset and eliminates a possible memory leak. This is
>> verified by 12 fewer warnings during the devicetree unittest,
>> as the possible memory leak warnings about #address-cells and
> Still missing the rest...
> And what about my other comments too?

Apologies, paper bag. Will fix all.


>> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
>> ---
>> Changes since v3:
>> - for errors of an overlay changing the value of #size-cells or
>> #address-cells, return -EINVAL so that overlay apply will fail
>> - for errors of an overlay changing the value of #size-cells or
>> #address-cells, make the message more direct.
>> Old message:
>> OF: overlay: ERROR: overlay and/or live tree #size-cells invalid in node /soc/base_fpga_region
>> New message:
>> OF: overlay: ERROR: changing value of /soc/base_fpga_region/#size-cells not allowed
>> drivers/of/overlay.c | 42 +++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 39 insertions(+), 3 deletions(-)