Re: [PATCH v3 2/9] dt-bindings: ti-lmu: Remove LM3697
From: Dan Murphy
Date: Fri Oct 19 2018 - 07:43:05 EST
On 10/18/2018 05:10 PM, Pavel Machek wrote:
>>>>>> Given this one seems to have not really been finished, it's probably
>>>>>> okay to make changes in this case. Still, it would be good to see
>>>>>> patches structured so that it's obvious we're breaking things. But how
>>>>>> the patches are structured doesn't matter until there's some agreement
>>>>>> on the end result.
>>>>> OK, so if I'm getting it right, the correct patch structure in this case
>>>>> means that changes removing bindings from MFD and moving them along
>>>>> with the modifications to the LED subsystem should be placed in a single
>>>>> Dan, could you please arrange the next patch set version accordingly?
>>>> Yes I can squash the DT bindings patches and call it a "move and modify"
>>> You can do move without problems. But if you plan to modify them,
>>> please try to change as little as possible, make it separate patch and
>>> explain why new version is better than old one.
>> I have been thinking of how to do this. Since the 2 devices are part of the current
>> binding there really is not a way to move them. Since there are still MFD capable
>> devices available.
>> I would still need to remove the current active binding and create a new binding in the LED
>> bindings directory.
>> I would have to remove and create in the same patch.
> Yeah, and this all is a sign that you should just keep the current
> binding, and make your code use it, see?
No I don't actually see this as a sign. This is just operational issues
nothing to do with actually correcting the incomplete unused bindings.
And actually moving and creating the bindings in the same patch makes
sense as the change is self contained in a single patch and is easier to
> You are free to use Sebastian's updated binding. It has "suggested by:
> Rob" or something like that on it, so it should be fine.
> You can add note to bindings/leds pointing to mfd binding.
> Now... this is what I've suggested before. If you don't agree, you may
> want to contact Tony Lindgren, IIRC he works for TI, too, and might be
> willing to help.
I will ping Tony just to close the loop. I will be posting v4 today after making the changes.
I was hoping to have some code review prior to posting v4 but have not received any comments so
v4 will just be a patch rearrangement.
> Thank you,