Re: [PATCH 09/15] Platform: OLPC: add a regulator for the DCON
From: Andy Shevchenko
Date: Fri Oct 19 2018 - 09:39:49 EST
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkundrak@xxxxx> wrote:
> All OLPC ECs are able to turn the power to the DCON on an off. Use the
> regulator framework to expose the functionality.
> +static int olpc_ec_set_dcon_power(struct olpc_ec_priv *ec, bool state)
> + unsigned char ec_byte = state;
> + int ret;
> + if (ec->dcon_enabled == state)
> + return 0;
> + ret = olpc_ec_cmd(EC_DCON_POWER_MODE, &ec_byte, 1, NULL, 0);
> + if (ret == 0)
> + ec->dcon_enabled = state;
> + return ret;
I would prefer to see usual pattern, i.e.
This comment applies to entire series. (Yes, you might address an old
code in a separate patch to be on consistent side)
> + return olpc_ec_set_dcon_power(ec, 1);
defined as boolean, supplied an int. Not good.
> + return olpc_ec_set_dcon_power(ec, 0);
> +static int dcon_regulator_is_enabled(struct regulator_dev *rdev)
> + return ec->dcon_enabled;
With Best Regards,