Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

From: David Howells
Date: Fri Oct 19 2018 - 11:44:50 EST

Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:

> As per statx(2) man page only clear out flags that are unsupported by the
> fs or have an unrepresentable value. Atime is supported by NFS as long as
> it's supported on the server.
> So the STATX_ATIME flag should not be cleared in the result_mask if the
> operation was requested on a MNT_NOATIME or MNT_NODIRATIME mount.
> This patch doesn't change the revalidation algorithm in any way, just the
> clearing of flags in stat->result_mask.
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
> Fixes: 9ccee940bd5b ("Support statx() mask and query flags parameters")
> Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>