Re: [PATCH 0/2] boot to a mapped device
From: Helen Koike
Date: Fri Oct 19 2018 - 12:28:02 EST
Sorry the delay of my reply.
On 9/27/18 3:31 PM, Mike Snitzer wrote:
> On Thu, Sep 27 2018 at 12:36pm -0400,
> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> On Thu, Sep 27, 2018 at 7:23 AM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
>>> On Wed, Sep 26 2018 at 3:16am -0400,
>>> Richard Weinberger <richard.weinberger@xxxxxxxxx> wrote:
>>>> On Wed, Sep 26, 2018 at 7:01 AM Helen Koike <helen.koike@xxxxxxxxxxxxx> wrote:
>>>>> This series is reviving an old patchwork.
>>>>> Booting from a mapped device requires an initramfs. This series is
>>>>> allows for device-mapper targets to be configured at boot time for
>>>>> use early in the boot process (as the root device or otherwise).
>>>> What is the reason for this patch series?
>>>> Setting up non-trivial root filesystems/storage always requires an
>>>> initramfs, there is nothing
>>>> wrong about this.
>>> Exactly. If phones or whatever would benefit from this patchset then
>>> say as much.
>> I think some of the context for the series was lost in commit logs,
>> but yes, both Android and Chrome OS do not use initramfs. The only
>> thing that was needed to do this was being able to configure dm
>> devices on the kernel command line, so the overhead of a full
>> initramfs was seen as a boot time liability, a boot image size
>> liability (e.g. Chrome OS has a limited amount of storage available
>> for the boot image that is covered by the static root of trust
>> signature), and a complexity risk: everything that is needed for boot
>> could be specified on the kernel command line, so better to avoid the
>> whole initramfs dance.
>> So, instead, this plumbs the dm commands directly instead of bringing
>> up a full userspace and performing ioctls.
Sorry about the missing context, I should've added the change log and
worked a bit more in the cover letter with a more verbose explanation on
the reasons for this patch.
Just for reference (I'll describe better the changes in the next version):
>>> I will not accept this patchset at this time.
>>>>> Example, the following could be added in the boot parameters.
>>>>> dm="lroot,,,rw, 0 4096 linear 98:16 0, 4096 4096 linear 98:32 0" root=/dev/dm-0
>>>> Hmmm, the new dm= parameter is anything but easy to get right.
>>> No, it isn't.. exposes way too much potential for users hanging
>> IIRC, the changes in syntax were suggested back when I was trying to
>> drive this series:
>> And it matches the "concise" format in dmsetup:
Exactly, this is the "concise" format from dmsetup, it also makes it
easier for users to copy and paste from "dmsetup --concise", which
doesn't mean this format is ideal, but imho keeping it consistent with
dmsetup is a good thing, please let me know if you have any other ideas.
>> What do you feel are next steps?
> There is quite a lot of init/ code, to handle parsing the concise DM
> format, that is being proposed for inclusion. I question why that
> DM-specific code would be located in init/
The main reason was that, taking "md=" and "raid=" as a reference, its
command line arguments are parsed in init/do_mounts_md.c, I could move
the parsing logic to drivers/md/* but I was wondering if it wouldn't be
better to be consistent with init/do_mounts_md.c, what do you think?
> There also needs to be a careful comparison done between the proposed
> init/ code to support consise DM format and the userspace lvm2
> equivalent (e.g. lvm2.git commit 827be0175)
Yes, I am taking a deeper look into the lvm2 parsing code, and actually
we can use almost the same logic for parsing, which seems better because
lvm2 is already using it, we already have some validation/review and it
also seems cleaner.
I'll update this in the next version.
> That aside, the DM targets that are allowed to be supported by this dm=
> commandline boot interface must be constrained (there are serious risks
> in allowing activation of certain DM targets without first using
> userspace tools to check the validity of associated metadata, as is done
> by the DM thin and cache targets). Also, all targets supported must be
> upstream. "linear", "verity" and "bootcache" DM targets are referenced
> in Documentation, "bootcache" must be a Google target. I'm not aware of
I see, I can add this constraint and I'll clean up the documentation for
the next version.
Thank you all for your comments and reviews, I am working on the next
version of this patch series taking yours comments into consideration
and cleaning up several parts of the code and documentation.
Please let me know if you have any other concerns.