Re: [RFC PATCH v2 02/17] soc/tegra: fuse: Export tegra_get_chip_id()

From: Dmitry Osipenko
Date: Sun Oct 21 2018 - 17:33:53 EST


On 10/21/18 11:54 PM, Dmitry Osipenko wrote:
> This function is used by tegra20-cpufreq driver which can be built as a
> kernel module.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/soc/tegra/fuse/tegra-apbmisc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index e5a4d8f98b10..c94dccf3eb30 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -51,6 +51,7 @@ u8 tegra_get_chip_id(void)
> {
> return (tegra_read_chipid() >> 8) & 0xff;
> }
> +EXPORT_SYMBOL_GPL(tegra_get_chip_id);
>
> u32 tegra_read_straps(void)
> {
>

A quick note.. I just recalled about existence of the of_machine_is_compatible() which will be more appropriate to use in the driver, hence this patch won't be needed.