Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

From: Nick Desaulniers
Date: Mon Oct 22 2018 - 13:18:00 EST

On Mon, Oct 22, 2018 at 2:43 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Mon, Oct 22, 2018 at 11:41 AM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > * clang does *not* support the attribute in C.
> ...nor the warning at all, by the way (which is why this is OK).
> Cheers,
> Miguel

Oh? We're going through and annotating all of Android's C++ source
right now with it.

Though it looks like the attribute syntax I like from GCC is not yet
supported in Clang.
I'll take a look at adding support.

So Kees sent me this embarrassing example:
(try changing the language from C++ to C; it works)! That's embarrassing!
Will get these both fixed up.
~Nick Desaulniers